Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix the double quotes caused eval() bug #443

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Conversation

tx2002
Copy link
Contributor

@tx2002 tx2002 commented Nov 26, 2024

fix: #440

src/main/java/org/casbin/jcasbin/model/Policy.java Outdated Show resolved Hide resolved
src/main/java/org/casbin/jcasbin/model/Policy.java Outdated Show resolved Hide resolved
src/main/java/org/casbin/jcasbin/model/Policy.java Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.86%. Comparing base (8dd4940) to head (060c258).

Files with missing lines Patch % Lines
...java/org/casbin/jcasbin/main/InternalEnforcer.java 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
+ Coverage   66.75%   66.86%   +0.11%     
==========================================
  Files          60       60              
  Lines        2966     2976      +10     
  Branches      548      549       +1     
==========================================
+ Hits         1980     1990      +10     
  Misses        809      809              
  Partials      177      177              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tx2002 tx2002 changed the title feat: fix the addPolicy bug feat: fix the double quotes caused eval() bug Dec 1, 2024
@hsluoyz hsluoyz merged commit 50d1967 into casbin:master Dec 2, 2024
4 checks passed
Copy link

github-actions bot commented Dec 2, 2024

🎉 This PR is included in version 1.77.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]Adding a policy that contains double quotes will cause an exception in the eval function
3 participants